wrong return code if only a single violation found #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if only a single violation was found, eg: ``` ========== Running: bundle exec rails-route-checker The following 1 url and path methods don't correspond to any route. - app/views/time_off_mailer/_entry.html.haml:40 - call to entry_calendar_url ========== Finished in 29.68s: bundle exec rails-route-checker ``` `issues?` would return `false`, when it should have returned `true`
daveallie
added a commit
that referenced
this pull request
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if only a single violation was found, eg:
issues?would returnfalse, when it should have returnedtrue. 2 or more violations give the expected outcome: